Enhance chip label for RTL direction#6701
Open
shlomoi10 wants to merge 1 commit into
Open
Conversation
Add RTL support for chip label.
|
@shlomoi10 is attempting to deploy a commit to the HeroUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add RTL support for Chip label bidi rendering.
Closes #
📝 Description
Fix incorrect bidi ordering for numeric-leading email-like strings inside
Chipwhen the document direction is RTL.Example:
123@example.comcan render with characters visually reordered in RTL contexts.This PR adds an RTL-specific CSS rule to the Chip label slot to ensure the browser resolves bidi direction per text run.
⛳️ Current behavior (updates)
When
dir="rtl"is applied at the document/app level, aChipthat displays values like:123@example.com123@domain.co.ilmay appear visually reversed or incorrectly ordered, even though the string contains no Hebrew characters.
This is caused by the Unicode bidirectional algorithm interacting with RTL context + numeric-leading tokens.
🚀 New behavior
In RTL context, Chip label text uses
unicode-bidi: plaintext, which makes the browser determine directionality based on the label’s content, preventing the reorder issue for numeric-leading email-like strings.Suggested change (in Chip styles, next to
.chip__label):