Skip to content

Conversation

apricote
Copy link
Member

@apricote apricote commented Aug 7, 2025

We collect all changes for the Storage Box support (#1117) in this PR. It will only be merged when everything is implemented through smaller pull requests targeting the storage-boxes branch.

Closes #1117

@apricote apricote mentioned this pull request Aug 7, 2025
11 tasks
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 68.59666% with 320 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.21%. Comparing base (7ea267e) to head (cc1cb63).

Files with missing lines Patch % Lines
internal/hcapi2/storage_box_type.go 8.69% 42 Missing ⚠️
internal/cmd/storagebox/rollback_snapshot.go 41.66% 28 Missing and 7 partials ⚠️
internal/cmd/storagebox/create.go 77.87% 17 Missing and 8 partials ⚠️
internal/cmd/storagebox/change_type.go 55.31% 14 Missing and 7 partials ⚠️
internal/cmd/storagebox/enable_protection.go 68.25% 14 Missing and 6 partials ⚠️
internal/hcapi2/storage_box.go 17.39% 19 Missing ⚠️
internal/cmd/storagebox/enable_snapshot_plan.go 76.92% 12 Missing and 6 partials ⚠️
internal/cmd/storagebox/update_access_settings.go 70.00% 12 Missing and 6 partials ⚠️
internal/cmd/storagebox/folders.go 71.15% 9 Missing and 6 partials ⚠️
internal/cmd/storagebox/list.go 66.66% 14 Missing and 1 partial ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   70.33%   70.21%   -0.12%     
==========================================
  Files         245      267      +22     
  Lines       10772    11789    +1017     
==========================================
+ Hits         7576     8278     +702     
- Misses       2509     2750     +241     
- Partials      687      761      +74     
Flag Coverage Δ
e2e 49.78% <27.34%> (-2.12%) ⬇️
unit 64.28% <66.24%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07 phm07 force-pushed the storage-boxes branch 2 times, most recently from a73c39e to 2a8203f Compare September 18, 2025 10:31

accessSettings := storageBox.AccessSettings
cmd.Println("Access Settings:")
cmd.Printf(" Reachable Externally:\t\t%t\n", accessSettings.ReachableExternally)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed, should we use util.YesNo here?

@phm07 phm07 force-pushed the storage-boxes branch 2 times, most recently from b49423e to cc1cb63 Compare September 22, 2025 09:49
apricote and others added 10 commits October 9, 2025 15:03
Adds support for the Hetzner API (`https://api.hetzner.com`) with a new
option to configure the API endpoint:

- Config Key: `hetzner-endpoint`
- Flag: `--hetzner-endpoint`
- Environment Variable: `HETZNER_ENDPOINT`

Co-authored-by: Julian Tölle <[email protected]>
Adds the CRUD commands `hcloud storage-box-type describe` and `hcloud
storage-box-type list`.

Related to #1117

---------

Co-authored-by: lukasmetzner <[email protected]>
`snapshot_limit` and `automatic_snapshot_limit` are pointers now.
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <[email protected]>
This PR implements actions for Storage Boxes.
This PR adds support for Storage Box Snapshots
This PR implements the Storage Box Subaccount resource.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support for Storage Boxes
3 participants