feat(server,load-balancer): add --ip-range argument to attach-to-network commands #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
+ Coverage 70.33% 70.35% +0.02%
==========================================
Files 245 245
Lines 10772 10782 +10
==========================================
+ Hits 7576 7586 +10
Misses 2509 2509
Partials 687 687
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola
reviewed
Sep 24, 2025
Comment on lines
30
to
+31
| cmd.Flags().IP("ip", nil, "IP address to assign to the Load Balancer (auto-assigned if omitted)") | ||
| cmd.Flags().IPNet("ip-range", net.IPNet{}, "IP range in CIDR block notation of the subnet to attach to") |
There was a problem hiding this comment.
We may want to update both docstrings.
ip-range would also fit the (auto-assigned if omitted) case, if ip is not provided.
In the API you can specify one of them, both, or none.
Comment on lines
30
to
+31
| cmd.Flags().IP("ip", nil, "IP address to assign to the Server (auto-assigned if omitted)") | ||
| cmd.Flags().IPNet("ip-range", net.IPNet{}, "IP range in CIDR block notation of the subnet to attach to") |
There was a problem hiding this comment.
Same docstring adjustment as for Load Balancers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
ip_rangeattribute was introduced into the API (Changelog). This PR implements new arguments to allow setting this property when attaching Servers or Load Balancers to a Network.