Skip to content

feat!: remove deprecated backup window flag #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat!: remove deprecated backup window flag #710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions internal/cmd/server/enable_backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ var EnableBackupCmd = base.Cmd{
TraverseChildren: true,
DisableFlagsInUseLine: true,
}
cmd.Flags().String(
"window", "",
"(deprecated) The time window for the daily backup to run. All times are in UTC. 22-02 means that the backup will be started between 10 PM and 2 AM.")
return cmd
},
Run: func(s state.State, cmd *cobra.Command, args []string) error {
Expand All @@ -35,11 +32,6 @@ var EnableBackupCmd = base.Cmd{
return fmt.Errorf("server not found: %s", idOrName)
}

window, _ := cmd.Flags().GetString("window")
if window != "" {
cmd.Print("[WARN] The ability to specify a backup window when enabling backups has been removed. Ignoring flag.\n")
}

action, _, err := s.Client().Server().EnableBackup(s, server, "")
if err != nil {
return err
Expand Down