[ARCHIVES] Change archives attribute to be a file. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archives is currently defined as a attr.string_list_dict which is a dictionary whos values are a list of strings. The versions structure is a dictionary of version to lists of dictionaries. There is no way to define this attribute structure in bazel, so instead take a json file which contains the archives.
Owner
|
Great addition, thanks! |
Owner
|
Given that we do not have a very large user base this is a semi-breaking change worth making |
Contributor
Author
np, thanks for accepting the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archives is currently defined as a attr.string_list_dict which is a dictionary whos values are a list of strings.
The versions structure is a dictionary of version to lists of dictionaries. There is no way to define this attribute structure in bazel, so instead take a json file which contains the archives.