fix: stop active tasks before server shutdown#878
fix: stop active tasks before server shutdown#878kanzihuang wants to merge 2 commits intohibiken:masterfrom
Conversation
9beba9b to
cc2d5d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #878 +/- ##
==========================================
+ Coverage 68.41% 68.73% +0.31%
==========================================
Files 27 28 +1
Lines 3841 3857 +16
==========================================
+ Hits 2628 2651 +23
+ Misses 929 919 -10
- Partials 284 287 +3 ☔ View full report in Codecov by Sentry. |
cc2d5d6 to
2996705
Compare
2996705 to
86c772f
Compare
|
@kanzihuang The shutdownTimeout will always re-queue jobs that did not complete before it quits. This PR changes behavior in that running tasks are stopped and requeued for next time without allowing the jobs to complete. |
@kamikazechaser After receiving the exit signal, the server does not wait for the task to stop before exiting. The test code is as follows, and the problem can be reproduced: This PR only addresses the above issues and does not change behavior in that running tasks are stopped and requeued for next time without allowing the jobs to complete. |
No description provided.