Conversation
pcmid
force-pushed
the
feat/dynamic_queue_with_concurrency
branch
from
541a69a to
2bace4c
Compare
pcmid
changed the title
pcmid
changed the title
|
any updates on this? where are we right now? |
This is a major feature. It could land on a testing branch for a few months before we release it on master just to smoke out any bugs. Also see the comments left by the linter. It would be good to also have feedback from @kanzihuang (if he is around). |
|
@kamikazechaser I recently retested this PR, and the results were perfect with no other issues. I believe it’s ready to be merged into the testing branch. |
|
Any updates on this issue? |
1 similar comment
|
Any updates on this issue? |
| // channel to communicate back to the long running "processor" goroutine. | ||
| // once is used to send value to the channel only once. | ||
| done chan struct{} | ||
| once sync.Once |
There was a problem hiding this comment.
I'd keep the original pattern for consistency (also used in Lease struct). Nothing against explicit initialization of the object.
There was a problem hiding this comment.
This change provides the ability to reset later by assigning a new *sync.Once.
There was a problem hiding this comment.
Oh, I just realized my mistake — it's assignment, not copying.
6 participants
Implemented #250, based on #879, cc @kanzihuang, with support for dynamically adding queues and controlling concurrency levels.
Not fully verified, butit works perfectly for my use case: a distributed spider with concurrency control.Known issues:
When the server is running, setting the queue concurrency does not take effect.