fix: replace deprecated JSON import assert syntax with with keyword #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace 'assert { type: "json" }' with 'with { type: "json" }' across
all public and kitchen-sink controllers.
- Resolves Node.js v20+ compatibility issues causing SyntaxError on startup
- Fixes issues hiteshchoudhary#288 and hiteshchoudhary#306 - application now starts successfully
- Updated 11 controller files to use modern import attribute syntax
This change ensures compatibility with Node.js v20+ where the assert keyword
for JSON imports has been deprecated in favor of the with keyword.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288
Fixes #306
Replace 'assert { type: "json" }' with 'with { type: "json" }' across all public and kitchen-sink controllers.
This change ensures compatibility with Node.js v20+ where the assert keyword for JSON imports has been deprecated in favor of the with keyword.