Fix/group chat error message #311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace 'assert { type: "json" }' with 'with { type: "json" }' across
all public and kitchen-sink controllers.
- Resolves Node.js v20+ compatibility issues causing SyntaxError on startup
- Fixes issues hiteshchoudhary#288 and hiteshchoudhary#306 - application now starts successfully
- Updated 11 controller files to use modern import attribute syntax
This change ensures compatibility with Node.js v20+ where the assert keyword
for JSON imports has been deprecated in favor of the with keyword.
Add automatic cart creation when user attempts to add items to non-existent cart. Add proper validation for cart operations that require existing cart. - Fix addItemOrUpdateItemQuantity to create cart if it doesn't exist - Add null checks in removeItemFromCart and clearCart functions - Fix syntax error with trailing comma in getCart aggregation - Resolves issue hiteshchoudhary#297 where API crashes when user has no cart This ensures new users can successfully add items to their cart and prevents 'Cannot read property items of null' errors.
Replace hardcoded production URL with dynamic server URL resolution.
Add improved environment-based URL detection logic.
- Update swagger.yaml to use placeholder template ${{server}}
- Enhance app.js to properly construct URLs based on environment
- Improve .env.sample documentation for FREEAPI_HOST_URL
- Fix issue hiteshchoudhary#303 where localhost URLs were not showing correctly in Swagger docs
The Swagger documentation now correctly shows the local development URL
instead of the production URL when running locally.
Separate duplicate detection from minimum member validation. Provide specific error messages for different validation failures. - Add explicit duplicate participant detection with clear error message - Improve minimum member count error with specific count information - Separate validation logic for better error reporting - Addresses issue hiteshchoudhary#282 by making validation errors more informative Users now get precise feedback about whether they have duplicates or insufficient participants when creating group chats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #282