Skip to content

fix for drag #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix for drag #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40bf9ac
Update package.json
damanwiththeplan Jun 29, 2018
61eec70
clear ripple properly
damanwiththeplan Jul 10, 2018
17733a5
Update package.json
damanwiththeplan Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vue-ripple-directive",
"version": "2.0.1",
"version": "2.1.0",
"description": "Vue Material Ripple Effect Directive",
"main": "src/ripple.js",
"repository": {
Expand Down
8 changes: 5 additions & 3 deletions src/ripple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ var Ripple = {
}, 850);

el.removeEventListener('mouseup', clearRipple, false);
el.removeEventListener('dragstart', clearRipple, false);
el.removeEventListener('mouseover', clearRipple, false);
el.removeEventListener('mouseleave', clearRipple, false);

// After removing event set position to target to it's original one
// Timeout it's needed to avoid jerky effect of ripple jumping out parent target
Expand All @@ -131,7 +132,8 @@ var Ripple = {

if(event.type === 'mousedown') {
el.addEventListener('mouseup', clearRipple, false);
el.addEventListener('dragstart', clearRipple, false);
el.addEventListener('mouseover', clearRipple, false);
el.addEventListener('mouseleave', clearRipple, false);
} else {
clearRipple();
}
Expand All @@ -148,4 +150,4 @@ function setProps(modifiers,props) {
});
}

export default Ripple;
export default Ripple;