Open
Conversation
raki123
commented
Dec 26, 2020
raki123
commented
- change to config.json is usefull but not necessary I think. I could change it to contain blanks instead of my specific solvers.
- change to dp/reader.py can not hurt and is necessary for using preprocessors that are different from pmc
- change to dpdb/problems/nesthdb.py is necessary: in case the number of variables was low enough to use only DB techniques the extra variables were not considered in the check whether they need to be introduced.
- change to nesthdb.py can not hurt and allows the usage of coprocessor as a secondary preprocessor that does current state of the art preprocessing for the SAT part of PMC.
…different preprocessor. Added the option to use two preprocessors (currently geared towards coprocessor). Added some missing code that caused sql queries to miss relevant parts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.