Skip to content

Add CLI diagnostics reporting support#22

Open
hoangsonww wants to merge 1 commit intomasterfrom
codex/add-feature-to-dbms
Open

Add CLI diagnostics reporting support#22
hoangsonww wants to merge 1 commit intomasterfrom
codex/add-feature-to-dbms

Conversation

@hoangsonww
Copy link
Copy Markdown
Owner

Summary

  • add a .diagnostics meta command to the interactive shell for viewing or exporting system diagnostics reports
  • record connections, query timings, and transaction outcomes so diagnostics metrics stay current
  • expose an API to refresh database metadata in the diagnostics subsystem during engine initialization

Testing

  • cmake -S . -B build -G Ninja
  • ninja -C build latticedb_shell

https://chatgpt.com/codex/tasks/task_e_68d74fe938bc832cbe57e0e838fa07a0

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lattice-db-next-gen-dbms Ready Ready Preview Comment Sep 27, 2025 2:53am

@hoangsonww hoangsonww requested a review from Copilot September 27, 2025 02:54
@hoangsonww hoangsonww self-assigned this Sep 27, 2025
@hoangsonww hoangsonww added bug Something isn't working duplicate This issue or pull request already exists enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Sep 27, 2025
@hoangsonww hoangsonww added this to the v2.3.0 milestone Sep 27, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CLI diagnostics reporting support to provide system status and performance metrics through an interactive shell command. The implementation includes connection and query timing tracking, transaction outcome recording, and flexible report export capabilities.

Key changes:

  • Added .diagnostics meta command for viewing/exporting system diagnostics in text or JSON format
  • Integrated diagnostics tracking into database engine for connections, queries, and transactions
  • Exposed API to update database metadata during engine initialization

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/engine/database_engine.cpp Integrates diagnostics tracking for database metadata, transaction commits/aborts
src/diagnostics/system_info.h Adds API method to update database configuration info
src/diagnostics/system_info.cpp Implements database info update with thread safety
cli_main.cpp Adds .diagnostics command with format/export options and connection/query tracking

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/engine/database_engine.cpp
Comment thread cli_main.cpp
Comment thread cli_main.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working codex duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Projects

Status: Ready

2 participants