[DRAFT] use integer ( maybe autoincrement on SQL) ids instead of UUID #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnav Gupta <[email protected]>
Signed-off-by: Arnav Gupta <[email protected]>
championswimmer
commented
Oct 23, 2017
lib/routes/create.js
Outdated
| @@ -34,7 +34,7 @@ createRoute.register = () => { | |||
| const theirs = request.params.data | |||
| theirResource = _.assign( | |||
| { | |||
| id: uuid.v4(), | |||
| id: 0, | |||
There was a problem hiding this comment.
This is 0 here as a "DEFAULT" value.
Putting the onus on the store handler (relattionaldb) to treat 0 = DEFAULT and if the value is 0, then generate new id, if not 0, then use it like a client provided id.
see championswimmer/jsonapi-store-sequelize@ee0b9f0#diff-8004fa36f21fa5eeb3c49b89106f6942R9 for example implementation
Signed-off-by: Arnav Gupta <[email protected]>
Signed-off-by: Arnav Gupta <[email protected]>
Signed-off-by: Arnav Gupta <[email protected]>
Signed-off-by: Arnav Gupta <[email protected]>
|
Now that we've merged #320, and as explained there the spec requires the id to be a string, do we still need this PR @championswimmer, or can we close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is not a "ready to merge" PR.
I took at look at #320 and it is not adequate to properly support integer IDs
This PR is the entire kitchen sink we need to be able to properly support integer IDs in both graphql and jsonapi.
I need some guidance on how best can this be integrated ? (using a possible resourceConfig.generatedId option)