Refactor Holon solve/workflow to explicit goal routing#745
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying holon with
|
| Latest commit: |
ecfd673
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b8ac8679.holon-1dl.pages.dev |
| Branch Preview URL: | https://refactor-goal-driven-holon-s.holon-1dl.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR refactors Holon’s solve/workflow routing to be explicitly goal-driven, adding a --goal flag and updating the GitHub workflows/action to resolve and pass an execution goal instead of relying on goal-hints/skill-based routing.
Changes:
- Add
holon solve --goaland implement default goal generation for PRs (review vs fix) and issues. - Update the composite action and reusable workflows to accept/resolve
goaland forward it intoholon solve. - Update templates/examples and tests to reflect the new goal-driven routing.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
cmd/holon/solve.go |
Adds explicit goal flag and new default goal generation (incl. PR review-signal inspection). |
cmd/holon/solve_test.go |
Updates goal-building tests to cover new PR/issue goal text helpers. |
.github/workflows/holon-solve.yml |
Replaces goal_hint with command_text, adds “Resolve execution goal”, and passes resolved goal to the action. |
.github/workflows/holon-trigger.yml |
Adds template comments for optional goal override. |
action.yml |
Replaces deprecated skill input with goal and forwards it to holon solve --goal. |
cmd/holon/templates/workflow.yml |
Updates workflow template comments for optional goal override. |
examples/workflows/holon-trigger.yml |
Updates example workflow comments for optional goal override. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Addressed all 3 review comments in commit
Validation run:
|
|
Verified that all 3 review comments from copilot-pull-request-reviewer have been addressed in commit ecfd673:
All review threads have been resolved. Changes verified via |
Summary
This PR switches Holon solve/workflow routing to explicit goal-driven behavior and removes goal-hint/skill-based solve routing:
holon solve --goaland make explicit goal highest priority.workflow.json trigger.goal_hintdependency and skill-derived goal assembly.holon solve:fixwhen unresolved review threads exist, or latest review state isCHANGES_REQUESTEDreviewinputs.goaland removeinputs.skill.goal_hintwithcommand_textand addResolve execution goalstep.with.goal) and action forwards--goaltoholon solve.goaloverride comments.Validation
go test ./cmd/holon.github/workflows/holon-solve.yml.github/workflows/holon-trigger.ymlexamples/workflows/holon-trigger.ymlcmd/holon/templates/workflow.ymlaction.yml