Skip to content

Refactor Holon solve/workflow to explicit goal routing#745

Merged
jolestar merged 2 commits intomainfrom
refactor/goal-driven-holon-solve-routing
Feb 27, 2026
Merged

Refactor Holon solve/workflow to explicit goal routing#745
jolestar merged 2 commits intomainfrom
refactor/goal-driven-holon-solve-routing

Conversation

@jolestar
Copy link
Collaborator

Summary

This PR switches Holon solve/workflow routing to explicit goal-driven behavior and removes goal-hint/skill-based solve routing:

  • Add holon solve --goal and make explicit goal highest priority.
  • Remove solve-time workflow.json trigger.goal_hint dependency and skill-derived goal assembly.
  • Add default PR intent routing in holon solve:
    • fix when unresolved review threads exist, or latest review state is CHANGES_REQUESTED
    • otherwise review
  • Add reusable workflow inputs.goal and remove inputs.skill.
  • Replace gate output goal_hint with command_text and add Resolve execution goal step.
  • Pass resolved goal into action (with.goal) and action forwards --goal to holon solve.
  • Update trigger examples/templates with optional goal override comments.

Validation

  • go test ./cmd/holon
  • YAML parse checks for:
    • .github/workflows/holon-solve.yml
    • .github/workflows/holon-trigger.yml
    • examples/workflows/holon-trigger.yml
    • cmd/holon/templates/workflow.yml
    • action.yml

Copilot AI review requested due to automatic review settings February 27, 2026 17:50
@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holon Ready Ready Preview, Comment Feb 27, 2026 6:15pm

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 27, 2026

Deploying holon with  Cloudflare Pages  Cloudflare Pages

Latest commit: ecfd673
Status: ✅  Deploy successful!
Preview URL: https://b8ac8679.holon-1dl.pages.dev
Branch Preview URL: https://refactor-goal-driven-holon-s.holon-1dl.pages.dev

View logs

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors Holon’s solve/workflow routing to be explicitly goal-driven, adding a --goal flag and updating the GitHub workflows/action to resolve and pass an execution goal instead of relying on goal-hints/skill-based routing.

Changes:

  • Add holon solve --goal and implement default goal generation for PRs (review vs fix) and issues.
  • Update the composite action and reusable workflows to accept/resolve goal and forward it into holon solve.
  • Update templates/examples and tests to reflect the new goal-driven routing.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cmd/holon/solve.go Adds explicit goal flag and new default goal generation (incl. PR review-signal inspection).
cmd/holon/solve_test.go Updates goal-building tests to cover new PR/issue goal text helpers.
.github/workflows/holon-solve.yml Replaces goal_hint with command_text, adds “Resolve execution goal”, and passes resolved goal to the action.
.github/workflows/holon-trigger.yml Adds template comments for optional goal override.
action.yml Replaces deprecated skill input with goal and forwards it to holon solve --goal.
cmd/holon/templates/workflow.yml Updates workflow template comments for optional goal override.
examples/workflows/holon-trigger.yml Updates example workflow comments for optional goal override.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jolestar
Copy link
Collaborator Author

Addressed all 3 review comments in commit ecfd673:

  1. Workflow regex word-boundary bug
  • Replaced \b with POSIX-safe boundary matching in .github/workflows/holon-solve.yml.
  1. Issue goal contract consistency
  • Updated issue-side workflow-resolved goal text to include the same manifest/status/outcome contract language used by CLI defaults.
  1. PR intent routing test coverage
  • Added inferPRIntentFromSignals(...) helper in cmd/holon/solve.go.
  • Added table-driven tests in cmd/holon/solve_test.go covering:
    • unresolved threads => fix
    • CHANGES_REQUESTED => fix
    • no signals => review

Validation run:

  • go test ./cmd/holon
  • YAML parse check for .github/workflows/holon-solve.yml

@holonbot
Copy link
Contributor

holonbot bot commented Feb 27, 2026

Verified that all 3 review comments from copilot-pull-request-reviewer have been addressed in commit ecfd673:

  1. Workflow regex word-boundary bug (.github/workflows/holon-solve.yml:709)

    • Fixed with POSIX-safe boundary pattern: (^|[^[:alnum:]_])(review|re-review|recheck)($|[^[:alnum:]_])
  2. Issue goal contract consistency (.github/workflows/holon-solve.yml:716)

    • Updated issue goal text to include full manifest/status/outcome contract language matching buildIssueGoal()
  3. PR intent routing test coverage (cmd/holon/solve.go)

    • Added inferPRIntentFromSignals() helper
    • Added table-driven tests in cmd/holon/solve_test.go covering:
      • unresolved threads => fix
      • CHANGES_REQUESTED => fix
      • no signals => review

All review threads have been resolved. Changes verified via go test ./cmd/holon - all new tests pass.

@jolestar jolestar merged commit 163972f into main Feb 27, 2026
18 checks passed
@jolestar jolestar deleted the refactor/goal-driven-holon-solve-routing branch February 27, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants