AcadianGY 12.3.9: ops\$CSI_SCALE knob for climate weighting#42
Merged
Conversation
Adds one optional parameter to AcadianGYOneStand: ops$CSI_SCALE. When set, multiplies the resolved Climate Site Index right after parsing, before anything downstream uses it. Default unset (no scaling); 12.3.9 with no CSI_SCALE in ops is byte-identical to 12.3.8. The change is one block of 3 R lines right after the CSI resolution. Version tag bumped to AcadianV12.3.9. v28 validation (100 ME FIA plots, 10 yr, MORTCAL + ingrowth on): CSI_SCALE BA bias R^2 TPA QMD 1.0 (=v24) +11.05% 0.4232 1043 4.92 0.7 (rec) +9.96% 0.4325 1035 4.94 0.5 (agg) +9.04% 0.4411 1029 4.95 CSI_SCALE not set reproduces v24 exactly (backward compat verified). CSI_SCALE=0.7 matches the v25 sensitivity interpolation; CSI_SCALE=0.5 lands TPA at observed and pulls BA bias below +10% for the first time. Production recommendations: - Customrun bridge default: CSI_SCALE=0.7 (~1 pp BA closure) - Optional aggressive: CSI_SCALE=0.5 (~2 pp, watch over-tuning) - Canadian MAGPlot: leave unset (no residual climate signal there) Deployed to fvsOL/inst/extdata/AcadianGY.R with 12.3.8 backed up. The +15% BA residual is now down to ~+9% at CSI_SCALE=0.5; the remainder sits in dDBH base-rate coefficients, mortality functional form, or a true Acadian-variant ceiling. All paper-sized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one optional knob to AcadianGYOneStand: `ops$CSI_SCALE`. When set, multiplies the resolved Climate Site Index by the provided factor before anything downstream uses it. Default unset; 12.3.9 with no CSI_SCALE in ops is byte-identical to 12.3.8.
The change
In AcadianGYOneStand, immediately after the CSI resolution line:
```r
CSI = if (is.null(stand) || is.null(stand$CSI) || is.na(stand$CSI)) 12 else stand$CSI
if (!is.null(ops$CSI_SCALE) && is.finite(ops$CSI_SCALE) && ops$CSI_SCALE > 0) {
CSI <- CSI * ops$CSI_SCALE
}
```
Version tag: AcadianV12.3.9.
v28 validation (100 ME FIA plots, 10 yr, MORTCAL + ingrowth on)
CSI_SCALE unset reproduces v24 exactly. CSI_SCALE=0.7 matches the v25 sensitivity interpolation. CSI_SCALE=0.5 lands TPA at observed and pulls BA bias below +10% for the first time.
Recommendations
Deployed to fvsOL/inst/extdata/AcadianGY.R with 12.3.8 backed up alongside the earlier 12.3.5/12.3.6/12.3.7 backups.