feat: expose ScrollTrigger and globalTimelines via composables #38
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey, had you had a chance to give this a look? |
|
Hey @holux-design, sorry to bother, will you have some time to look at this soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Lukas,
In my current project (and most others) I frequently have to refresh ScrollTrigger from time to time and mostly when navigating to other pages.
My current use case is that my Footer component exists in the layout and does not 'change' on page navigations, so its reveal animations are not displayed properly on pages with different heights.
If I do ScrollTrigger.refresh() on slug nav they get nicely refreshed. However if I import via 'gsap/ScrollTrigger' it doesnt work as it is not the same instance.
For this reason I create a composable that exposes v-gsap-nuxt's ScrollTrigger and all is good.
While I was at it, I exposed globalTimelines if they might be needed, but have no use case for now.
Final thought - my prettier was formatting your files wrong, so I added some stuff in .vscode/settings.json - let me know if they are okay or I need to remove em.
Cheers