Add reconfiguration flow to Indevolt integration#165132
Open
Xirt wants to merge 2 commits intohome-assistant:devfrom
Open
Add reconfiguration flow to Indevolt integration#165132Xirt wants to merge 2 commits intohome-assistant:devfrom
Xirt wants to merge 2 commits intohome-assistant:devfrom
Conversation
|
Hey there @xirtnl, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reconfiguration flow to the Indevolt integration so users can change the configured host address after initial setup, and marks the integration’s quality scale reconfiguration requirement as complete.
Changes:
- Implement
async_step_reconfigurein the Indevolt config flow to validate the device at the new host and update/reload the config entry. - Add UI strings for the reconfigure step and new abort reasons (successful reconfigure, different device).
- Extend config flow tests to cover reconfigure success, error recovery, and unique-id mismatch/different-device scenarios.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
homeassistant/components/indevolt/config_flow.py |
Adds async_step_reconfigure that validates the device and updates+reloads the existing entry. |
homeassistant/components/indevolt/strings.json |
Adds translations for the reconfigure step and abort reasons used by the new flow. |
homeassistant/components/indevolt/quality_scale.yaml |
Marks reconfiguration-flow as done. |
tests/components/indevolt/test_config_flow.py |
Adds reconfiguration-flow test coverage (success, errors, different device). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds reconfiguration flow to the Indevolt integration (incl. tests), allowing users to reconfigure the host address.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: