Skip to content

Fix missing Gen-2 sensor for the Indevolt integration#165133

Merged
zweckj merged 2 commits intohome-assistant:devfrom
Xirt:fix-missing-sensor-1505
Mar 9, 2026
Merged

Fix missing Gen-2 sensor for the Indevolt integration#165133
zweckj merged 2 commits intohome-assistant:devfrom
Xirt:fix-missing-sensor-1505

Conversation

@Xirt
Copy link
Contributor

@Xirt Xirt commented Mar 8, 2026

Proposed change

Add missing "Cumulative production" sensor for Gen-2 devices (already present in Gen-1 and documentation).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings March 8, 2026 12:04
@home-assistant
Copy link

home-assistant bot commented Mar 8, 2026

Hey there @xirtnl, mind taking a look at this pull request as it has been labeled with an integration (indevolt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of indevolt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign indevolt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing “Cumulative production” (1505) sensor to Indevolt Gen-2 devices so it is created and polled like it already is for Gen-1, and updates the sensor snapshot expectations accordingly.

Changes:

  • Expose the cumulative_production sensor (1505) for Gen-2 by removing the Gen-1-only restriction in the sensor description.
  • Ensure Gen-2 polling requests key 1505 by adding it to the Gen-2 SENSOR_KEYS list.
  • Update sensor snapshot tests to include the new Gen-2 entity.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/indevolt/sensor.py Makes 1505 (cumulative_production) available for Gen-2 entity creation.
homeassistant/components/indevolt/const.py Adds 1505 to the Gen-2 polled key list so the coordinator requests the value.
tests/components/indevolt/snapshots/test_sensor.ambr Updates snapshots to expect the new Gen-2 sensor entity.

@zweckj zweckj added this to the 2026.3.2 milestone Mar 9, 2026
@zweckj zweckj merged commit 9a5f509 into home-assistant:dev Mar 9, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants