-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Implement loading / layout view transitions #27281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
On the Overview page, the scrollbar behaves weirdly. Starts from the 8th second on the recording. Not sure if this is related to the change. |
|
Should we respect |
|
Discussed with design, we should also explore the view transitions api |
717af6b to
d4e1362
Compare
|
I know this is WIP, but I don't feel the correct transition is being used for the sidebar. As you can see in the video, there are weird glitches/lags on the UI elements, they should use some subtle animation (slide-in?) and render near instant. Just thought I chime in, in case this hasn't been changed or mentioned already. |
aa55047 to
ab1c736
Compare
This is removed now (it was mostly a test). This PR is to focus solely on panel/page transitions, other view transitions can be investigated later |
Discussed with design, general agreement that animations should be set to 0 when reduced motion is set. This is now the case |
5dc95fa to
7f1b582
Compare
4636355 to
83512e6
Compare
Breaking change
Proposed change
Sets up a new mixin to be used for view transitions between layouts, providing css defined fade in / crossfade view transitions. Also adds a fade out for the launch screen so the transition between loading and the panel should be less abrupt and hopefully reduce element "pop-in".
Applies view transitions to:
Some changes I've deferred for later PRs. These are listed in the related task: #27238 (feel free to contribute other ideas here)
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: