Hash phone number on url img #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hanaawad24 ! This looks nice, would you like to add a small comment about this change? Thanks! |
|
emi420
reviewed
Oct 21, 2025
There was a problem hiding this comment.
Hi @hanaawad24, first of all, thank you for contributing!
The image element currently looks like this:
<img class="popupImage" alt="00000005-PHOTO-2025-01-09-12-23-16.jpg" src="blob:https://chatmap.hotosm.org/6dd20e55-54e2-442e-8fea-b280807247db">User’s phone is not included into the src or the alt attributes.
Why would we need to include the phone number as a hash string ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the ability to hash the number of the user in the image url src