Wrapping flight gap identification in UI #738
Wrapping flight gap identification in UI #738allisonsibrian wants to merge 7 commits intohotosm:devfrom
Conversation
…nary and reformatting, tests refactored to test new changes, adding backend routes
…eview, creating modal for flight review
… for drone type, altitude, global side median
for more information, see https://pre-commit.ci
fed3d91 to
b33cad1
Compare
|
I rebased this on the latest photo uploader changes on dev & moved things around a little - it's looking great! Had to force push though for the rebase, sorry - it might mean you need to git reset you branch to this |
|
Oh also, I had to add a dropdown for the user to select their drone model. I think the flight gap identification does belong as part of this workflow, but the problem with the project details page is that the user doesn't select a drone type (that's only on the task details page, where they generate flightplans). So we need to also ask the user which drone it's a flightplan for =) |
|
The main detector is built for trajectory analysis: it skips any segment with fewer than 20 images, hence:
There is a sparse-coverage fallback, that should trigger when there are 5 images or fewer in the segment (
I need to test this with the generate-flight-gaps script in https://github.com/spwoodcock/drone-testdata-freetown-1 (which is much more applicable and a valid test) Ideal scenario:
|
…orkflow Assisted by: Codex 5.3 LLM
|
Thanks Sam! I appreciate you revising and adding these changes, as well as testing thoroughly! |






What type of PR is this? (check all applicable)
Related Issue
Fixes #512
Describe this PR
Draft PR that wraps flight gap identification into a UI accessible to users.
Updates on the flight gap identification function:
- Note: For drone type, a hard variable is not set if an image does not have drone type metadata. I am not sure if this is an issue for users.
For Routes:
For Frontend:
Screenshots
Alternative Approaches Considered
Review Guide
My next steps consist of:
A few things to note on the screenshots provided:
Please let me know if these changes would make sense for users structurally. I personally thought separating the buttons during the ImageReview Process made sense, but I am open to overall feedback, especially on how this aspect/feature should look for users (e.g, button colors, if sidebar is needed, etc.).
Sorry this took a while. I've been busy, and this was my first time making frontend changes, so I wanted to make sure I understood all of these different pieces and how they played together!
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?