BC-12000 - Add unique connectionName to every RabbitMQWrapperModule.register() call#6379
Merged
Conversation
…n FilesStorageAMQPClientModule
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds explicit, unique RabbitMQ connection names to each RabbitMQWrapperModule.register() usage to prevent connection/provider collisions when multiple RabbitMQ modules are registered in the server.
Changes:
- Adds
connectionNameto all existingRabbitMQWrapperModule.register()call sites (provisioning + infra modules). - Extends
RabbitMQModuleOptionswith an optionalconnectionNamefield. - Passes
connectionNamethrough to@golevelup/nestjs-rabbitmqvia thenameconfig property in the wrapper module.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/server/src/modules/provisioning/schulconnex-license-provisioning-consumer.module.ts | Adds a dedicated RabbitMQ connectionName for the license provisioning consumer. |
| apps/server/src/modules/provisioning/schulconnex-group-removal-consumer.module.ts | Adds a dedicated RabbitMQ connectionName for the group removal consumer. |
| apps/server/src/modules/provisioning/schulconnex-group-provisioning-consumer.module.ts | Adds a dedicated RabbitMQ connectionName for the group provisioning consumer. |
| apps/server/src/modules/provisioning/provisioning.module.ts | Adds a dedicated RabbitMQ connectionName for the provisioning module connection. |
| apps/server/src/infra/rabbitmq/rabbitmq.module.ts | Wires connectionName into the underlying RabbitMQ module config (name). |
| apps/server/src/infra/rabbitmq/rabbitmq-module.options.ts | Adds connectionName?: string to the shared RabbitMQ module options interface. |
| apps/server/src/infra/mail/mail.module.ts | Ensures the mail module’s RabbitMQ registration uses a named connection (mail). |
| apps/server/src/infra/h5p-editor-client/h5p-editor-client.module.ts | Ensures the H5P editor client RabbitMQ registration uses a named connection (h5p-editor). |
| apps/server/src/infra/files-storage-amqp-client/files-storage-amqp-client.module.ts | Ensures the files storage AMQP client RabbitMQ registration uses a named connection (files-storage). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ptions interface" This reverts commit 5fb3d6d.
SevenWaysDP
approved these changes
Jul 9, 2026
SevenWaysDP
approved these changes
Jul 9, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
Changes
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.