-
-
Notifications
You must be signed in to change notification settings - Fork 135
Add VGC teampreview functionality into environments #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #780 +/- ##
==========================================
- Coverage 83.38% 83.13% -0.25%
==========================================
Files 39 47 +8
Lines 3918 5628 +1710
==========================================
+ Hits 3267 4679 +1412
- Misses 651 949 +298 🚀 New features to boost your workflow:
|
|
@hsahovic this is ready for review whenever you get a chance! |
|
I could be convinced this makes sense, but my understanding is that this is trying to rely on |
|
@hsahovic I'm doing that because choose_move is gathering decisions from the |
I've been sitting on this code for a while but I didn't want to contribute it until I could figure out a minimal implementation, but now I have so here you go! This adds VGC teampreview as part of the MDP, overriding the previous default random action that was taken at teampreview for agents in the environment. The total teampreview, which looks like "/team wxyz" where w, x, y, and z are numbers from 1 to 6, is determined by two doubles orders given by the agent. The first order gives the Pokemon to choose in teampreview that are represented by w and x, and the second order gives y and z.