Fix C++1 generation of function pointers. #1406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
hsutter
requested changes
Jul 27, 2025
| @@ -7266,7 +7266,8 @@ class parser | |||
| auto type_id( | |||
| bool allow_omitting_type_name = false, | |||
| bool allow_constraint = false, | |||
| bool allow_function_type = false | |||
| bool allow_function_type = false, | |||
| bool allow_qualified_function_type = true | |||
There was a problem hiding this comment.
This new parameter doesn't seem to be used - it always has its default value. Should it just be removed?
| @@ -7339,7 +7340,9 @@ class parser | |||
| assert (n->id.index() == type_id_node::unqualified); | |||
| } | |||
| else if (std::unique_ptr<function_type_node> id = {}; | |||
| allow_function_type | |||
| (allow_function_type || | |||
| (allow_qualified_function_type && | |||
hsutter
added
the
question - further information requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1397. Function pointers (but not functions) can now be return types.
It turns out that even if we correctly parse a function pointer type, we drop the pc_qualifiers when we generate the C++1 code. So I fixed that too.