Skip to content

WIP: doc updates #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP: doc updates #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d5d5a3
add specifier
NullVoxPopuli May 24, 2020
ba160f5
add a way to get workers from test?
NullVoxPopuli May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ember/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ A build chain for WebWorkers in Ember applications with intuitive ergonomics.
## Usage

To use a worker in your application or addon, you first have to define
a new worker in a top-level `workers/` directory in your project.
a new worker in a top-level `workers/` directory in the root your project (as opposed to `app/`).

> **Example 1**
>
Expand Down
7 changes: 7 additions & 0 deletions packages/ember/addon-test-support/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { getContext } from '@ember/test-helpers';

export function getWorker(name) {
Copy link
Contributor Author

@NullVoxPopuli NullVoxPopuli May 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this'd be TS'

getWorker<K extends keyof WorkerRegistry>(name: K): WorkerRegistry[K] {

}

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't set up ts support for the ember portions of this project just yet, but yeah that would be something nice :)

let { owner } = getContext();

return owner.lookup('service:-workers').getWorker(name);
}