Skip to content

Make async-h1 the default client, don't build with wasm by default. #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Make async-h1 the default client, don't build with wasm by default. #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0362fc
Crate: export with the async-h1 client by default
Fishrock123 Sep 7, 2020
bc098cd
Crate: feature flag the wasm client.
Fishrock123 Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ edition = "2018"
[features]
# when the default feature set is updated, verify that the `--features` flags in
# `.github/workflows/ci.yaml` are updated accordingly
default = ["native-client", "middleware-logger", "encoding"]
h1-client = ["wasm-client", "http-client/h1_client"]
default = ["h1-client", "middleware-logger", "encoding"]
h1-client = ["http-client/h1_client"]
native-client = ["curl-client", "wasm-client", "http-client/native_client"]
curl-client = ["http-client/curl_client"]
wasm-client = ["http-client/wasm_client"]
Expand Down
4 changes: 2 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@
//!
//! # Features
//! The following features are available.
//! - __`h1-client`:__ use `async-h1` on the server and `window.fetch` in the browser.
//! - __`native-client` (default):__ use `curl` on the server and `window.fetch` in the browser.
//! - __`h1-client` (default):__ use `async-h1` (non-wasm).
//! - __`native-client`:__ use `curl-client` on the server and `window.fetch` in the browser.
//! - __`middleware-logger` (default):__ enables logging requests and responses using a middleware.
//! - __`curl-client`:__ use `curl` (through `isahc`) as the HTTP backend.
//! - __`wasm-client`:__ use `window.fetch` as the HTTP backend.
Expand Down