Skip to content

[i18n-ko] Translated vector_search_with_hub_as_backend.ipynb to Korean - #299

Merged
stevhliu merged 9 commits into
huggingface:mainfrom
whybe-choi:docs/vector_search_with_hub_as_backend
Sep 18, 2025
Merged

[i18n-ko] Translated vector_search_with_hub_as_backend.ipynb to Korean#299
stevhliu merged 9 commits into
huggingface:mainfrom
whybe-choi:docs/vector_search_with_hub_as_backend

Conversation

@whybe-choi

Copy link
Copy Markdown
Contributor

What does this PR do?

Translated the vector_search_with_hub_as_backend.ipynb file to Korean.

Who can review?

Hello, @merveenoyan ! Could you please review my PR when you have a chance?
Thank you :)

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@whybe-choi whybe-choi changed the title [i18n-ko] Translated vector_search_with_hub_as_backend.ipynb to Korean [i18n-ko] Translated vector_search_with_hub_as_backend.ipynb to Korean May 17, 2025
@merveenoyan

Copy link
Copy Markdown
Collaborator

Hello and thanks for this PR! Can we get another Korean speaker to check this 👀

@mreraser

Copy link
Copy Markdown
Contributor

Hello and thanks for this PR! Can we get another Korean speaker to check this 👀

Hello @whybe-choi! May I review your translation?

@mreraser mreraser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice translation! Good job 👍

Here are a few suggestions!

Comment thread notebooks/ko/_toctree.yml Outdated
Comment thread notebooks/ko/index.md Outdated
Comment thread notebooks/ko/vector_search_with_hub_as_backend.ipynb Outdated
Comment thread notebooks/ko/vector_search_with_hub_as_backend.ipynb Outdated
Comment thread notebooks/ko/vector_search_with_hub_as_backend.ipynb Outdated
whybe-choi and others added 6 commits September 17, 2025 00:17
Co-authored-by: Jiwook Han <33192762+mreraser@users.noreply.github.com>
Co-authored-by: Jiwook Han <33192762+mreraser@users.noreply.github.com>
Co-authored-by: Jiwook Han <33192762+mreraser@users.noreply.github.com>
Co-authored-by: Jiwook Han <33192762+mreraser@users.noreply.github.com>
Co-authored-by: Jiwook Han <33192762+mreraser@users.noreply.github.com>
@whybe-choi

Copy link
Copy Markdown
Contributor Author

Hi, @stevhliu !
I would be grateful for your feedback on this PR when you have a spare moment🙂
Your insights would be very helpful. Thank you for your time!

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! 🙌

@stevhliu
stevhliu merged commit f3ecb3d into huggingface:main Sep 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants