Add roformer to NormalizedConfigManager - #2465
Open
Pateljainam069 wants to merge 2 commits into
Open
Conversation
RoFormer uses the standard hidden_size/num_attention_heads/num_hidden_layers naming (verified against transformers.RoFormerConfig), so it maps directly to NormalizedTextConfig like bert/roberta. Part of huggingface#351.
…ion, ibert, levit, mobilebert, mobilevit to NormalizedConfigManager All ten map onto the existing NormalizedTextConfig / NormalizedVisionConfig patterns with no new subclasses needed: - NormalizedTextConfig (hidden_size/num_attention_heads/num_hidden_layers): convbert, data2vec-text, ibert, mobilebert - NormalizedVisionConfig (image_size/num_channels): beit, convnext, convnextv2, data2vec-vision, levit, mobilevit Each was verified against the corresponding transformers config class (model_type string, attribute presence, and an end-to-end NormalizedConfigManager.get_normalized_config_class(...) round trip). Part of huggingface#351.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
NormalizedConfigManagerraises aKeyErrorforroformerbecause it'smissing from the
_confmapping inoptimum/utils/normalized_config.py,blocking ONNX Runtime optimization for RoFormer models.
RoFormerConfiguses the standardhidden_size/num_attention_heads/num_hidden_layersnaming (verified againsttransformers.RoFormerConfig),so it maps directly to
NormalizedTextConfig, same asbert/roberta—no new normalized config class needed.
Part of #351.
Before submitting
Who can review?
@echarlaix @JingyaHuang @michaelbenayoun @IlyasMoutawwakil
Two notes on what I changed: