FIX: Missing device map for facebook/opt-125m #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the failing EETQ test in the nighly multi device CI. In huggingface#2612, fixed device_maps were added for multi-GPU training as we could not rely on device_map="auto". While doing this change, one device_map was missing, namely for facebook/opt-125m, which is used in the EETQ multi device test. This device_map was now added. This makes the test pass locally.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Note: Failing tests are unrelated and fixed via #2676. This PR only affects GPU tests, so the CPU CI is irrelevant here. |
githubnemo
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the failing EETQ test in the nighly multi device CI.
In #2612, hard coded
device_maps were added for multi-GPU training as we could not rely ondevice_map="auto". While doing this change, onedevice_mapwas missing, namely forfacebook/opt-125m, which is used in the EETQ multi device test. Thisdevice_mapwas now added. This makes the test pass locally.