Skip to content

Replace HubApi downloader with swift-huggingface HubClient #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 17 commits into from
Mar 3, 2026
Merged

Replace HubApi downloader with swift-huggingface HubClient #315

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
92a4b42
Replace HubApi downloader with swift-huggingface HubClient
mattt Feb 19, 2026
e4ae3c4
Opt out Linux from redirect handling to avoid crashing
mattt Feb 19, 2026
5d91672
Fix Linux crash caused by setting Location header into request
mattt Feb 19, 2026
b2f090b
Emit final completion progress on cancellation after download finishes
mattt Feb 24, 2026
cf2fd54
Avoid hardcoding single background session identifier
mattt Feb 24, 2026
bf7af69
Incorporate feedback from review
mattt Feb 24, 2026
33d6eec
Bump swift-huggingface dependency to be from 0.8.0
mattt Feb 24, 2026
c0493bf
Fix download destination
pcuenca Feb 25, 2026
d5dfae1
Temporarily set completedUnitCount outside the lock
pcuenca Feb 25, 2026
0a331ca
Bridge HubClientError to existing DownloadError
mattt Mar 2, 2026
59e48d7
Inline makeHubClient
mattt Mar 2, 2026
f70493d
Revert swift-huggingface pre 0.8.1 workaround
mattt Mar 2, 2026
d97d1f8
Make localTokenizerFromPretrained deterministic by cleaning cache bef…
mattt Mar 2, 2026
6fef966
Replace use of force unwrapping
mattt Mar 2, 2026
98db9a2
Fix documentation comment for HEAD request method
mattt Mar 2, 2026
2a9ccf9
Replace Boolean with XCTestExpectation in testDownloadWithRevision
mattt Mar 2, 2026
5fc64c1
Update Package.swift
mattt Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ let package = Package(
],
dependencies: [
.package(url: "https://github.com/huggingface/swift-jinja.git", from: "2.0.0"),
.package(url: "https://github.com/huggingface/swift-huggingface.git", from: "0.8.0"),
Comment thread
mattt marked this conversation as resolved.
Outdated
Comment thread
mattt marked this conversation as resolved.
Outdated
.package(url: "https://github.com/apple/swift-collections.git", from: "1.0.0"),
.package(url: "https://github.com/apple/swift-crypto.git", "3.0.0"..<"5.0.0"),
.package(url: "https://github.com/ibireme/yyjson.git", exact: "0.12.0"),
Expand All @@ -28,6 +29,7 @@ let package = Package(
name: "Hub",
dependencies: [
.product(name: "Jinja", package: "swift-jinja"),
.product(name: "HuggingFace", package: "swift-huggingface"),
.product(name: "OrderedCollections", package: "swift-collections"),
.product(name: "Crypto", package: "swift-crypto"),
.product(name: "yyjson", package: "yyjson"),
Expand Down
Loading
Loading