-
Notifications
You must be signed in to change notification settings - Fork 30.3k
🌐 [i18n-KO] Translated main_classes/peft.md
#39515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 [i18n-KO] Translated main_classes/peft.md
#39515
Conversation
LGTM! 번역 고생하셨습니다 👍 |
cc @stevhliu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_toctree.yml 확인 부탁드려요~
클래스 설명에 대해 수정 제안 올려보았는데, 같이 고민해보면 좋을거같습니다. 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we can merge once the feedback has been addressed!
f9c011d
to
f429bd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 감사하고 고생많으셨습니다 🤗
Added a table of contents (TOC) to the documentation, specifically for the `transformers.integrations.PeftAdapterMixin` section, following the structure and content outlined in [this link](https://huggingface.co/docs/transformers/main/en/main_classes/peft#transformers.integrations.PeftAdapterMixin).
Changed '관리하기 위한' to '관리할 수 있도록' for more natural Korean expression when describing the purpose of providing functions.
Changed '~할 수 없기 때문에' to '~할 수 없어' for more concise expression while maintaining clarity.
Changed '주입할 수 없어' to '적용할 수 없어' for better readability. Considered alternatives: '삽입': Too literal translation of 'inject' '입력': Could be misunderstood as data input '통합': Implies merging two systems '추가': Simple but less precise '적용' was chosen as it's the most natural and widely used term in Korean technical documentation for this context.
Changed the toctree path from 'PEFT' (uppercase) to 'peft' (lowercase) to match the correct directory naming convention and prevent broken links.
24b9e73
to
da49dfb
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Translated the
main_classes/peft.md
file of the documentation to Korean.Thank you in advance for your review.
Part of #20179
Before reviewing
[[lowercased-header]]
)Who can review? (Initial)
May you please review this PR?
@4N3MONE, @yijun-lee, @jungnerd , @harheem
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review? (Final)
@stevhliu May you please review this PR?