Skip to content

Conversation

AhnJoonSung
Copy link
Contributor

@AhnJoonSung AhnJoonSung commented Jul 19, 2025

What does this PR do?

Translated the pipeline_gradio.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?
@4N3MONE, @yijun-lee, @jungnerd , @harheem

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

@4N3MONE
Copy link
Contributor

4N3MONE commented Jul 19, 2025

LGTM! 번역 고생하셨습니다 😃

Copy link
Contributor

@yijun-lee yijun-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@harheem harheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤗

BTW, glossary에서는 machine learning과 기계학습이 매핑되어 있습니다. 기계학습보다는 저도 머신 러닝이 더 나은 것 같은데, glossary를 변경하는 것에 대해 제안해봅니다 (cc @4N3MONE @yijun-lee @jungnerd)

@4N3MONE
Copy link
Contributor

4N3MONE commented Jul 22, 2025

LGTM 🤗

BTW, glossary에서는 machine learning과 기계학습이 매핑되어 있습니다. 기계학습보다는 저도 머신 러닝이 더 나은 것 같은데, glossary를 변경하는 것에 대해 제안해봅니다 (cc @4N3MONE @yijun-lee @jungnerd)

저는 기계학습 쪽도 괜찮다고 생각하는 편이긴 하지만 더 많이 쓰이는 단어 측면에서 생각하면 머신러닝도 좋은 것 같아요!

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, feel free to mark as ready for review once you're ready!

@AhnJoonSung AhnJoonSung force-pushed the ko-pipeline_gradio.md branch from 326afcb to 53c8696 Compare July 26, 2025 09:28
@AhnJoonSung AhnJoonSung marked this pull request as ready for review July 26, 2025 09:43
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 9f38763 into huggingface:main Jul 29, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants