fix(voxtral): correct typo in apply_transcription_request #39572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rev2607
force-pushed
the
fix-transcription-typo
branch
from
63f00ea to
0b6229d
Compare
qubvel
reviewed
Jul 22, 2025
There was a problem hiding this comment.
Thanks for the fix! I also found this typo while looking into the demo code
https://huggingface.co/spaces/MohamedRashad/Voxtral/blob/main/app.py#L62
To make smooth fix we should also update
voxtral.md- fix typo in model cards on the Hub (3B and 24B)
- make sure demos will work after the update (make corresponding PR's to fix the typo)
As an intermediate step, we can support both methods for a while, e.g.
# method with typo
def apply_transcrition_request(self, *args, **kwargs):
warning.warn("Method is deprecated, please use `apply_transcription_request` ...")
return apply_transcription_request(*args, **kwargs)
rev2607
force-pushed
the
fix-transcription-typo
branch
from
5a52ef1 to
c98c0ad
Compare
|
@rev2607 can you please update |
|
Thanks, @qubvel. I've updated voxtral.md as requested. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
run-slow: voxtral |
|
This comment contains run-slow, running the specified jobs: models: ['models/voxtral'] |
|
Checking slow tests (likely compute related) |
|
run-slow: voxtral |
|
This comment contains run-slow, running the specified jobs: models: ['models/voxtral'] |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: voxtral |
ArthurZucker
approved these changes
Jul 25, 2025
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e#39572) * fix(voxtral): correct typo in apply_transcription_request * temporary wrapper: apply_transcrition_request * Update processing_voxtral.py * style: sort imports in processing_voxtral.py * docs(voxtral): fix typo in voxtral.md * make style * doc update --------- Co-authored-by: eustlb <[email protected]> Co-authored-by: Eustache Le Bihan <[email protected]>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e#39572) * fix(voxtral): correct typo in apply_transcription_request * temporary wrapper: apply_transcrition_request * Update processing_voxtral.py * style: sort imports in processing_voxtral.py * docs(voxtral): fix typo in voxtral.md * make style * doc update --------- Co-authored-by: eustlb <[email protected]> Co-authored-by: Eustache Le Bihan <[email protected]>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e#39572) * fix(voxtral): correct typo in apply_transcription_request * temporary wrapper: apply_transcrition_request * Update processing_voxtral.py * style: sort imports in processing_voxtral.py * docs(voxtral): fix typo in voxtral.md * make style * doc update --------- Co-authored-by: eustlb <[email protected]> Co-authored-by: Eustache Le Bihan <[email protected]>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e#39572) * fix(voxtral): correct typo in apply_transcription_request * temporary wrapper: apply_transcrition_request * Update processing_voxtral.py * style: sort imports in processing_voxtral.py * docs(voxtral): fix typo in voxtral.md * make style * doc update --------- Co-authored-by: eustlb <[email protected]> Co-authored-by: Eustache Le Bihan <[email protected]>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e#39572) * fix(voxtral): correct typo in apply_transcription_request * temporary wrapper: apply_transcrition_request * Update processing_voxtral.py * style: sort imports in processing_voxtral.py * docs(voxtral): fix typo in voxtral.md * make style * doc update --------- Co-authored-by: eustlb <[email protected]> Co-authored-by: Eustache Le Bihan <[email protected]>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e#39572) * fix(voxtral): correct typo in apply_transcription_request * temporary wrapper: apply_transcrition_request * Update processing_voxtral.py * style: sort imports in processing_voxtral.py * docs(voxtral): fix typo in voxtral.md * make style * doc update --------- Co-authored-by: eustlb <[email protected]> Co-authored-by: Eustache Le Bihan <[email protected]>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e#39572) * fix(voxtral): correct typo in apply_transcription_request * temporary wrapper: apply_transcrition_request * Update processing_voxtral.py * style: sort imports in processing_voxtral.py * docs(voxtral): fix typo in voxtral.md * make style * doc update --------- Co-authored-by: eustlb <[email protected]> Co-authored-by: Eustache Le Bihan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a typo in the method name
apply_transcrition_request→apply_transcription_requestinsidesrc/transformers/models/voxtral/processing_voxtral.py.This PR addresses issue #39530. The method was misspelled and is now corrected for clarity and consistency. This change may also require updates in model cards if this method is referenced there.
Fixes #39530
Before submitting
Who can review?
@speech models: @eustlb