-
Notifications
You must be signed in to change notification settings - Fork 30.3k
revert behavior of _prepare_from_posids #39622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ArthurZucker
merged 2 commits into
huggingface:main
from
winglian:fa-prepare-qkv-from-posids-revert
Jul 24, 2025
Merged
revert behavior of _prepare_from_posids #39622
ArthurZucker
merged 2 commits into
huggingface:main
from
winglian:fa-prepare-qkv-from-posids-revert
Jul 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this won't work for inference! can we just have a if else!
(Thanks a lot for checking sorry for breaking) |
ArthurZucker
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks makes sense!
5 tasks
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
* revert behavior of _prepare_from_posids * add back cu_seqlens_k and max_k for inference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#39474 causes the grad norm to become NaN during training. We don't need to revert the whole thing, but reverting just this function seems to fix the regression.
@ArthurZucker @SunMarc
pre-#39474 loss

post-#39474 loss

with this fix

Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.