Fix Flash Attention query_length validation to be compile-friendly#40399 #40412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Thanks for your efforts. Thinking it's better for now. |
does the cicd test fail really matter? i change my code status to main andtest it locally ,but still failed... |
|
See #40399 (comment), #40424 will introduce a proper fix as |
| @@ -409,6 +409,22 @@ def _prepare_from_posids(query, key, value, position_ids, query_length): | |||
| (max_seqlen_in_batch_q, max_seqlen_in_batch_k) (`tuple[int]`): | |||
| Maximum sequence length in batch (`max_seqlen_in_batch_q` for the target sequence i.e. query, `max_seqlen_in_batch_k` for the source sequence i.e. key/value). | |||
| """ | |||
| # Validate query_length only when not compiling to avoid graph breaks | |||
| try: | |||
| if not torch._dynamo.is_compiling(): | |||
There was a problem hiding this comment.
You may want to use
from .utils.import_utils import is_torchdynamo_compiling
|
We also find similar NaN mistake on Ascend NPU without this PR, can we push it to be merged? |
|
@FightingZhen can you test #40424 instead? We shouldn't enter this path at all anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.