[generate] PromptLookupCandidateGenerator accepts bad_words_ids
#40726
+17
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[For maintainers] Suggested jobs to run (before merge) run-slow: idefics2, idefics3, qwen2_5_vl, smolvlm |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
reviewed
Sep 5, 2025
| @@ -1019,11 +1019,15 @@ def __init__( | |||
| num_output_tokens: int = 10, | |||
| max_matching_ngram_size: Optional[int] = None, | |||
| max_length: int = 20, | |||
| bad_words_ids: Optional[list[list[int]]] = None, | |||
There was a problem hiding this comment.
maybe somewhere to explain this in more details.
I get the idea, but not clear about the format, like why it's a list of list of int, and below it is converted to list of tensors, and how this format is sued in the actual logic if any(bad_word_id.to(chosen_ids.device) in chosen_ids for bad_word_id in self.bad_words_ids):.
Just nit but would be nice to have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title.
In the process, deflakes a lot of tests :) (It was generating forbidden tokens in tests, like image tokens in VLMs -- now we can specify which sequences are forbidden)
py.test tests/models/voxtral/test_modeling_voxtral.py -k test_prompt_lookup_decoding_matches_greedy_search --flake-finder --flake-runs 1000now runs with without problems.