Skip to content

Conversation

@tux3
Copy link
Contributor

@tux3 tux3 commented Nov 25, 2025

I noticed that the open page in browser shortcut had not worked for me in a long time. I compared to the code for open history in browser (which does work), and found that the actionOpen_page_in_browser was not connected to anything.

The right handler seems to be on_actionOpen_in_a_browser_triggered, which is a slightly different name for the same action.

There is also on_actionDisplay_this_page_in_browser_triggered, which is yet another one. I'm not sure I know what the difference is between these two, but this patch is enough to fix the disconnected "O" shortcut.

(The IDE also wanted to strip a couple trailing spaces while saving the file)

The actionOpen_page_in_browser was not connected to anything,
the right handler seems to be on_actionOpen_in_a_browser_triggered,
which is a slightly different name for the same action
@benapetr
Copy link
Member

Hello, I will have a look into this but I just used Huggle recently and I remember I was using O shortcut extensively and it worked just fine. Were you trying latest release?

@benapetr
Copy link
Member

so I did a quick code check and it seems that - Open page in a browser is indeed disconnected from everything, Open in a browser is hard-wired to O shortcut via the .ui file? Need to double check on it

If I recall correctly the difference between these 2 is that Open page should open the page eg. for [[test]] it would go to /wiki/test, while just Open in browser opens whatever is being rendered, most likely a diff itself in the browser.

Definitely needs some cleanup

@tux3
Copy link
Contributor Author

tux3 commented Nov 25, 2025

Hello, I will have a look into this but I just used Huggle recently and I remember I was using O shortcut extensively and it worked just fine. Were you trying latest release?

Could this be a Qt5/Qt6 difference? I build from source with Qt6, but I do remember it working fine in the past (and when I ran a Git blame on these lines, the last changes were from 2014, so how it worked in the past/was supposed to work I don't fully understand yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants