Fix open in browser shortcut using wrong action name #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the open page in browser shortcut had not worked for me in a long time. I compared to the code for open history in browser (which does work), and found that the
actionOpen_page_in_browserwas not connected to anything.The right handler seems to be
on_actionOpen_in_a_browser_triggered, which is a slightly different name for the same action.There is also
on_actionDisplay_this_page_in_browser_triggered, which is yet another one. I'm not sure I know what the difference is between these two, but this patch is enough to fix the disconnected "O" shortcut.(The IDE also wanted to strip a couple trailing spaces while saving the file)