test / gateway-core-connectors#7367
Conversation
…into feat/gateway-core
1 similar comment
| try: | ||
| resp: Dict[str, Any] = await self._get_gateway_instance().get_price( | ||
| self.chain, self.network, self.connector_name, base, quote, amount, side | ||
| ) |
There was a problem hiding this comment.
to remove commented code
cardosofede
left a comment
cardosofede
left a comment
There was a problem hiding this comment.
a few comments to improve the PR but we can work on it next on the next dev since the gateway is already merged.
| ) | ||
| transaction_hash: Optional[str] = order_result.get("txHash") | ||
| if transaction_hash is not None and transaction_hash != "": | ||
| # gas_cost: Decimal = Decimal(order_result.get("gasCost")) |
There was a problem hiding this comment.
to remove commented code
| self._in_flight_orders_snapshot = {k: copy.copy(v) for k, v in self._order_tracker.all_orders.items()} | ||
| self._in_flight_orders_snapshot_timestamp = self.current_timestamp | ||
|
|
||
| async def _update_balances(self): |
There was a problem hiding this comment.
maybe is not necessary 2 methods that do the same thing, usually the public method should call the private one
| self._get_gas_estimate_task.cancel() | ||
| self._get_chain_info_task = None | ||
|
|
||
| async def _status_polling_loop(self): |
There was a problem hiding this comment.
this method can be abstracted in the base class
| self._get_gas_estimate_task.cancel() | ||
| self._get_chain_info_task = None | ||
|
|
||
| async def _status_polling_loop(self): |
There was a problem hiding this comment.
this method can be abstracted in the base class
| "buy_fee": self._last_buy_fee, | ||
| "sell_fee": self._last_sell_fee, | ||
| "total_fee": self._last_tx_cost, | ||
| # "amm_gas_price": self.config.gas_conversion_price, |
thanks - I will address these comments in the next release. |
4 participants
Test branch that integrates with hummingbot/gateway#380