Fix linkedin auth considering new apis#2030
Closed
ChrisWayFor wants to merge 1 commit intohwi:masterfrom
Closed
Conversation
Member
|
LinkedinResourceOwnerTest needs to be fixed. |
|
In the meantime, we can use the oAuth2 provider: I did not manage to make it work all the time: I get a linkedin:
type: oauth2
class: \HWI\Bundle\OAuthBundle\OAuth\ResourceOwner\OAuth2ResourceOwner
client_id: '%env(LINKEDIN_CLIENT_ID)%'
client_secret: '%env(LINKEDIN_CLIENT_SECRET)%'
access_token_url: "https://www.linkedin.com/oauth/v2/accessToken"
authorization_url: "https://www.linkedin.com/oauth/v2/authorization"
infos_url: "https://api.linkedin.com/v2/userinfo"
scope: openid profile email
user_response_class: HWI\Bundle\OAuthBundle\OAuth\Response\PathUserResponse
paths:
identifier: sub
nickname: given_name
realname: name |
Contributor
|
@Khodl maybe this answer could help. I'm running into the same issue. |
Contributor
We could use the same strategy as laravel/socialite#662 (adding a new provider for new apps). |
|
@d9beuD I like your approach, as it does not break anything. Good job! |
Member
|
Fixed in #2039 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.