Correct MinMaxIdx function minIdx and maxIdx#1153
Open
HIGHER98 wants to merge 5 commits intohybridgroup:devfrom
Open
Correct MinMaxIdx function minIdx and maxIdx#1153HIGHER98 wants to merge 5 commits intohybridgroup:devfrom
HIGHER98 wants to merge 5 commits intohybridgroup:devfrom
Conversation
…rather than int. The return arrays will have input.dims elements. Adding test to confirm function is working with nD case.
…rather than int. The return arrays will have input.dims elements. Adding test to confirm function is working with nD case.
…rrors were occuring before because of a non-zero'd mat being created. Malloc'ing space for min and max index in MinMaxIdx rather than making array and passing in address to [0] index.
Author
|
The Appveyor tests appear to be failing for this PR, and I'm unsure why... 😕 The tests seem to be failing on something which I'm pretty sure should be unaffected by changes introduced here. Also, the most recent builds on Appveyor seem to be taking >30 minutes. I can see about a month ago, most builds were compiling in ~3 minutes. I suspect this is something cache-based and possibly has something to do with what's going awry. Any help would be appreciated! Tests are failing here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #1151
This PR looks into changing return type of
minIdxandmaxIdxin theMinMaxIdxfunction to be an[]intrather thanint, i.e.The return arrays will have input.dims elements.
Example:
In the above code snippet,
minValwill be 0,maxValwill be 17, minIdx will be[0,0], maxIdx will be[3,3]