-
Notifications
You must be signed in to change notification settings - Fork 245
fix(ios): add header search paths to resolve build error in RN 0.80+ #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @hyochan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This change provides a crucial fix for iOS builds in React Native projects, specifically targeting versions 0.80 and above. By correctly configuring the header search paths within the autolinking script, it ensures that the necessary generated files are found, preventing compilation failures and allowing projects to build successfully. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds necessary header search paths to the iOS podspec configuration to fix a build error with React Native 0.80+. The change correctly identifies the paths for generated C++ and iOS-specific headers. However, the modification is made directly to a generated file, which is not a sustainable solution. I've added a comment suggesting that this change should be moved to the file generator to ensure it persists.
# Add header search paths for generated files | ||
"HEADER_SEARCH_PATHS" => "$(inherited) \"${PODS_TARGET_SRCROOT}/nitrogen/generated/shared/c++\" \"${PODS_TARGET_SRCROOT}/nitrogen/generated/ios\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is being made in a generated file, which is explicitly advised against in the file header (DO NOT MODIFY THIS FILE
). This approach is brittle because the change will be lost if the file is regenerated by nitro
. To make the fix permanent, it should be applied to the nitro
generator that produces this file.
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No description provided.