Add support for K8s TLS terminated reverse-proxy scenarios #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byran Carlock <[email protected]>
teeohhem
reviewed
Apr 23, 2025
| @@ -11,7 +11,7 @@ metadata: | |||
| {{- end -}} | |||
| {{- end }} | |||
| spec: | |||
| replicas: {{ .Values.hyperdx.replicas | default 1 }} | |||
| replicas: 1 | |||
There was a problem hiding this comment.
We probably want to keep the replica setting for flexibility.
There was a problem hiding this comment.
Thanks, that was an accidental regression.
teeohhem
reviewed
Apr 23, 2025
…tion and security context Signed-off-by: Byran Carlock <[email protected]>
…flexibility and security context Signed-off-by: Byran Carlock <[email protected]>
…figuration Signed-off-by: Byran Carlock <[email protected]>
… values.yaml Signed-off-by: Byran Carlock <[email protected]>
…gMap Signed-off-by: Byran Carlock <[email protected]>
… in task-checkAlerts Signed-off-by: Byran Carlock <[email protected]>
|
@teeohhem I also fixed a couple of other bugs I found in the chart |
…ration Signed-off-by: Byran Carlock <[email protected]>
Signed-off-by: Byran Carlock <[email protected]>
teeohhem
reviewed
May 6, 2025
| logLevel: "info" | ||
| securityContext: | ||
| allowPrivilegeEscalation: |
There was a problem hiding this comment.
can you add a default here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous configuration required that you append the application port to all urls. This modification allows us to support TLS terminated reverse proxy scenarios. (ie- Istio, etc)