Fix addAction crash when called without optional attributes#218
Open
matsilva wants to merge 1 commit intohyperdxio:mainfrom
Open
Fix addAction crash when called without optional attributes#218matsilva wants to merge 1 commit intohyperdxio:mainfrom
matsilva wants to merge 1 commit intohyperdxio:mainfrom
Conversation
Guard setAttributes call so it's only invoked when attributes is defined, preventing Object.keys(undefined) crash in OpenTelemetry internals.
🦋 Changeset detectedLatest commit: 8eb924c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addAction(name)crashes when the optionalattributesargument is omitted becausespan.setAttributes(undefined)callsObject.keys()onundefinedinternallysetAttributescall so it only runs whenattributesis definedTest plan
addAction('name')without attributes does not throw and produces a spanaddAction('name', { key: 'value' })produces a span with the expected attribute