Skip to content

minor design tweaks to the search page filters UI. #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Dec 16, 2025
Merged

minor design tweaks to the search page filters UI. #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc9f2fa
minor design tweaks to the search page filters UI.
brandon-pereira Dec 15, 2025
e9d9ab2
add changeset
brandon-pereira Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-flies-rush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

Minor UI Improvements in Search Filters UI
116 changes: 75 additions & 41 deletions packages/app/src/components/DBSearchPageFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import {
IconChevronDown,
IconChevronRight,
IconChevronUp,
IconFilterOff,
IconPin,
IconPinFilled,
IconRefresh,
Expand Down Expand Up @@ -199,7 +200,7 @@ export const FilterCheckbox = ({
gap="xs"
wrap="nowrap"
justify="space-between"
pe={'11px'}
pe={'4px'}
miw={0}
>
<Text
Expand Down Expand Up @@ -239,16 +240,23 @@ export const FilterCheckbox = ({
data-testid={`filter-exclude-${label}`}
/>
)}
<TextButton
<ActionIcon
onClick={onClickPin}
label={pinned ? <IconPinFilled size={14} /> : <IconPin size={14} />}
size="xs"
variant="subtle"
color="gray"
aria-label={pinned ? 'Unpin field' : 'Pin field'}
role="checkbox"
aria-checked={pinned}
data-testid={`filter-pin-${label}`}
/>
>
{pinned ? <IconPinFilled size={12} /> : <IconPin size={12} />}
</ActionIcon>
</div>
{pinned && (
<Text size="xxs">
<Center me="1px">
<IconPinFilled size={12} />
</Text>
</Center>
)}
</div>
);
Expand Down Expand Up @@ -578,6 +586,7 @@ export const FilterGroup = ({
p="0"
pr="xxxs"
data-testid="filter-group-control"
style={{ overflow: 'hidden' }}
classNames={{
chevron: 'm-0',
label: 'p-0',
Expand All @@ -592,62 +601,87 @@ export const FilterGroup = ({
fz="xxs"
color="gray"
>
<Text size="xs" fw="500">
<Text size="xs" fw="500" truncate="end">
{name}
</Text>
</Tooltip>
</Accordion.Control>
<Group gap="xxxs" wrap="nowrap">
<Group gap={0} wrap="nowrap">
{!hasRange && (
<>
<ActionIcon
size="xs"
variant="subtle"
color="gray"
onClick={toggleShowDistributions}
title={
<Tooltip
label={
showDistributions
? 'Hide distribution'
: 'Show distribution'
? 'Hide Distribution'
: 'Show Distribution'
}
data-testid={`toggle-distribution-button-${name}`}
aria-checked={showDistributions}
role="checkbox"
position="top"
withArrow
fz="xxs"
color="gray"
>
{isFetchingDistribution ? (
<span className="spinner-border spinner-border-sm" />
) : showDistributions ? (
<IconChartBar size={14} />
) : (
<IconChartBarOff size={14} />
)}
</ActionIcon>
{onFieldPinClick && (
<ActionIcon
size="xs"
variant="subtle"
color="gray"
onClick={onFieldPinClick}
title={isFieldPinned ? 'Unpin field' : 'Pin field'}
me={'4px'}
onClick={toggleShowDistributions}
data-testid={`toggle-distribution-button-${name}`}
aria-checked={showDistributions}
role="checkbox"
>
{isFieldPinned ? (
<IconPinFilled size={14} />
{isFetchingDistribution ? (
<span className="spinner-border spinner-border-sm" />
) : showDistributions ? (
<IconChartBarOff size={14} />
) : (
<IconPin size={14} />
<IconChartBar size={14} />
)}
</ActionIcon>
</Tooltip>
{onFieldPinClick && (
<Tooltip
label={isFieldPinned ? 'Unpin Field' : 'Pin Field'}
position="top"
withArrow
fz="xxs"
color="gray"
>
<ActionIcon
size="xs"
variant="subtle"
color="gray"
onClick={onFieldPinClick}
>
{isFieldPinned ? (
<IconPinFilled size={14} />
) : (
<IconPin size={14} />
)}
</ActionIcon>
</Tooltip>
)}
</>
)}
{totalAppliedFiltersSize > 0 && (
<TextButton
label="Clear"
onClick={() => {
onClearClick();
setSearch('');
}}
/>
<Tooltip
label="Clear Filters"
position="top"
withArrow
fz="xxs"
color="gray"
>
<ActionIcon
size="xs"
variant="subtle"
color="gray"
onClick={() => {
onClearClick();
setSearch('');
}}
>
<IconFilterOff size={14} />
</ActionIcon>
</Tooltip>
)}
</Group>
</Center>
Expand Down
Loading