Skip to content

Add debug_span in poll_complete loop #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add debug_span in poll_complete loop #764

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be2512d
Add debug_span in poll_complete loop
YHM404 Apr 10, 2024
9953b5a
explain why it can fix memory leak
Apr 11, 2024
6768ed6
Merge pull request #1 from ikhin/zot6/fix-events-keep-growing
YHM404 Apr 11, 2024
4c9f551
Update src/proto/streams/prioritize.rs
YHM404 Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/proto/streams/prioritize.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,11 @@ impl Prioritize {
tracing::trace!("poll_complete");

loop {
// Create a new span at the start of the loop to avoid continuously
// adding events to the same span due to tracing in the loop, which
// would lead to an ongoing increase in memory usage.
let _span = tracing::debug_span!("poll_complete_loop").entered();

if let Some(mut stream) = self.pop_pending_open(store, counts) {
self.pending_send.push_front(&mut stream);
self.try_assign_capacity(&mut stream);
Expand Down