Fix the missing url in basic.md #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Apr 11, 2025
_stable/client/basic.md
Outdated
| [Response]: {{ site.hyper_docs_url }}/hyper/struct.Response.html | ||
| [Request]: {{ site.hyper_docs_url }}/hyper/struct.Request.html | ||
| [Response]: {{ site.http_docs_url }}/http/request/struct.Request.html | ||
| [Request]: {{ site.http_docs_urll }}/http/response/index.html |
Member
There was a problem hiding this comment.
Thanks for catching these! I noticed the change here has Response pointing at Request, and Request pointing at the response module. The should be swapped, and both link to the respective struct pages. Also, http_docs_urll has two Ls.
Contributor
Author
There was a problem hiding this comment.
My apologies, I’ll fix the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
_stable/client/basic.mdfile. The change updates the URLs for theResponseandRequestreferences to point to the correct documentation pages.Documentation updates:
_stable/client/basic.md: Updated the URLs forResponseandRequestreferences to point to the correct HTTP documentation pages.