Status Formatting and tls-connect-info feature into v0.14.x #2406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yperium#2402) ## Motivation hyperium#2360 ## Solution Added the `tls-connect-info` feature which derives from `_tls-any` feature. --------- Co-authored-by: Maple Xu <[email protected]>
## Motivation The `Status` struct is the canonical error message in `tonic`. Printing it currently prints out a very verbose and difficult-to-read message. ## Solution Improve `impl, Display for status` by: * Only printing the `message` if it is non-empty * Only printing the `metadata` if it is non-empty` * Always omitting the binary `details` (printing out `details: [22, 51, 50, 48, 51, 53, 98, 57, 50, 55, 50, 55, 100, 54, 101, …]` is not helping anyone)
LucioFranco
requested changes
Aug 29, 2025
|
What's the policy here, that's not something that needs to go into main right? I just make an extra commit here in this branch? |
xumaple
force-pushed
the
mapxu/status-and-connect-info-into-v014
branch
2 times, most recently
from
816e0bb to
38123ad
Compare
|
Okay, I solved this by just ff the v0.14.x branch from master, so we don't need this PR anymore since these commits are already there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution