tonic-web: proxy any kind of service #2418
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows applying the GrpcWebLayer to any kind of Service, not just ones that tonic generates. This makes it possible to use tonic-web as a grpc-web proxy to a gRPC server implemented in another language for example.
bouk
force-pushed
the
bouk/tonic-web-proxy
branch
from
973e2dc to
c8a4676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows applying the GrpcWebLayer to any kind of Service, not just ones that tonic generates.
Motivation
This makes it possible to use tonic-web as a grpc-web proxy to a gRPC server implemented in another language for example, I'm using it to proxy a Python gRPC service over grpc-web.
Solution
We have to be generic over the ResBody of the wrapped service and then box that into a
tonic::body::Body. I've made the default values of the body type parameterstonic::body::Bodyso I believe this change is backwards compatible.This is a redo of #1366