Allow configuring max_local_error_reset_streams #2421
Merged
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given there's now also references from h2, would it be possible to get this merged? (cc @tottoto perhaps? thanks) |
tottoto
requested changes
Oct 25, 2025
tottoto
reviewed
Oct 25, 2025
|
I'm not sure why the "CI / Interop Tests (macOS-latest)" test failed, but it looks unrelated? |
tottoto
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
@alexanderrilee Thanks! Could you squash the commits and upstream it to the default branch? I think I'd like to merge this pull request as a backport of it.
I'm not sure why the "CI / Interop Tests (macOS-latest)" test failed, but it looks unrelated?
Yes. It isn't related to this change.
alexanderrilee
force-pushed
the
configure-max-stream-resets
branch
from
7c3f006 to
3aba7c5
Compare
tottoto
pushed a commit
that referenced
this pull request
Oct 30, 2025
…2437) Squashed version of #2421 applied to `master`. Co-authored-by: alexanderrilee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This makes max_local_error_reset_streams configurable. We have an isolated environment where we create and close many (valid) short-lived gRPC streams. We very quickly hit the 1024 limit on stream resets, which initiates a GoAway. During connection recreation, the Python gRPC client misbehaves. We would like the option to tune this limit, since this is a safe traffic pattern for us.
Solution
I've added
http2_max_local_error_reset_streamsto theServerAPI.