fix(examples): Re-introduce the tower feature #2431
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2339 I was running into issues with
udepscheck in the CI. Theudepscheck runs on the entire Cargo workspace. When thetowerfeature exists in theexamplescrate, the check would fail with the following error why analysing thegrpccrate.This seems to be happening because cargo creates a feature for each optional dependency under the hood.
udepsis trying to find the feature namedtowerin the grpc crate, but can't find it.When I try to add a feature named
towerwhich simply enablesdep:tower, udeps complains that the feature is unused:I'm unsure if this is a bug in
udeps.I (incorrectly) assumed that the
towerfeature was not required in theexamplescrate and removed it. I re-checked and #2339 seems to have broken thetower-clientandtower-serverexamples' builds.This PR re-introduces the
towerfeature, fixing the tower examples, but breaks theudepscheck.